Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(counters_stable): add missing e2e tests #1251

Merged
merged 7 commits into from
Jun 30, 2023
Merged

test(counters_stable): add missing e2e tests #1251

merged 7 commits into from
Jun 30, 2023

Conversation

agilarity
Copy link
Contributor

@agilarity agilarity commented Jun 29, 2023 •
edited
Loading

READY FOR REVIEW

Supports #210

Provide 100% requirements coverage for the counters_stable example.

User Action Scenarios

  • Add 1000 Counters › should increase the number of counters
  • Add Counter › should increase the number of counters
  • Clear Counters › should reset the counts
  • Decrement Count › should decrease the total count
  • Enter Count › should increase the total count (NEW)
  • Enter Count › should decrease the total count (NEW)
  • Increment Count › should increase the total count
  • Remove Counter › should decrement the number of counters (NEW)
  • View Counters › should see the title
  • View Counters › should see the initial counts

@agilarity agilarity changed the title WIP - test(counters_stable): enter count test(counters_stable): add e2e tests for the enter count action Jun 29, 2023
@agilarity agilarity changed the title test(counters_stable): add e2e tests for the enter count action WIP test(counters_stable): add more e2e tests Jun 29, 2023
@agilarity agilarity changed the title WIP test(counters_stable): add more e2e tests WIP test(counters_stable): add missing e2e tests Jun 29, 2023
@agilarity agilarity changed the title WIP test(counters_stable): add missing e2e tests test(counters_stable): add missing e2e tests Jun 30, 2023
@gbj gbj merged commit df4ce90 into leptos-rs:main Jun 30, 2023
@agilarity agilarity deleted the cs-enter branch June 30, 2023 14:49
maccesch pushed a commit to maccesch/leptos that referenced this pull request Jun 30, 2023
@agilarity @maccesch
test(counters_stable): add missing e2e tests (leptos-rs#1251)
a6d556d 
* test(counters_stable): remove unused ids

* test(counters_stable): enter count

* refactor(counters_stable/e2e): improve test names

* refactor(counters_stable): move page object

* refactor(counters_stable/e2e): target nth counter

* test(counters_stable): remove counter

* refactor(counters_stable/e2e): change description
gbj pushed a commit that referenced this pull request Jul 7, 2023
@agilarity @gbj
test(counters_stable): add missing e2e tests (#1251)
2eeb94b 
* test(counters_stable): remove unused ids

* test(counters_stable): enter count

* refactor(counters_stable/e2e): improve test names

* refactor(counters_stable): move page object

* refactor(counters_stable/e2e): target nth counter

* test(counters_stable): remove counter

* refactor(counters_stable/e2e): change description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilarity @gbj