Allow any type that implements FromServerFnError as a replacement of the ServerFnError in server_fn #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd68c76.
ryo33
changed the title
|
@nicolas-guichard Hi, this fix is similar to #3253, but takes a different approach, addressing #3153 and #3155. It would be great if you could take a look and review whether this approach works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3270
Fixes #3153
Addresses #3155
FromServerFnErrorServerFnError::WrappedServerErrorvariant and manual error conversion helpersServerFnErrorErr::WrappedServerErrorandimpl From<ServerFnError> for ServerFnErrorErrserver_fn_macrosto use theFromServerFnErrortraitServerFnErrorErr::Middlewarefor a better context of the errorsexamples/server_fn_axumcargo +nightly make checkThe implementation is complete. The only breaking changes should be the third ones mentioned above, and other behaviors should remain retained as expected.