Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a doc typo and one broken intra-doc link #3341

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix a doc typo and one broken intra-doc link #3341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
726a994
Fix typo in Signal/ArcSignal
FreezyLemon Dec 9, 2024
6f5bdcc
Fix rustdoc link to ArenaItem on Sandboxed::new
FreezyLemon Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions reactive_graph/src/owner/arena.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,11 @@ pub mod sandboxed {
}

impl<T> Sandboxed<T> {
/// Wraps the given [`Future`], ensuring that any [`ArenaItem`] created while it is being
/// polled will be associated with the same arena that was active when this was called.
/// Wraps the given [`Future`], ensuring that any [`ArenaItem`][item] created while it is
/// being polled will be associated with the same arena that was active when this was
/// called.
///
/// [item]:[crate::owner::ArenaItem]
pub fn new(inner: T) -> Self {
let arena = MAP.with_borrow(|n| n.as_ref().and_then(Weak::upgrade));
Self { arena, inner }
Expand Down
4 changes: 2 additions & 2 deletions reactive_graph/src/wrappers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ pub mod read {
/// or derived signal closure.
///
/// This allows you to create APIs that take any kind of `ArcSignal<T>` as an argument,
/// rather than adding a generic `F: Fn() -> T`. Values can be access with the same
/// rather than adding a generic `F: Fn() -> T`. Values can be accessed with the same
/// function call, `with()`, and `get()` APIs as other signals.
pub struct ArcSignal<T: 'static, S = SyncStorage>
where
Expand Down Expand Up @@ -333,7 +333,7 @@ pub mod read {
/// an [`ReadSignal`], [`Memo`], [`RwSignal`], or derived signal closure.
///
/// This allows you to create APIs that take any kind of `Signal<T>` as an argument,
/// rather than adding a generic `F: Fn() -> T`. Values can be access with the same
/// rather than adding a generic `F: Fn() -> T`. Values can be accessed with the same
/// function call, `with()`, and `get()` APIs as other signals.
pub struct Signal<T, S = SyncStorage>
where
Expand Down
Loading