impl Dispose for Callback types and add try_run to the Callable trait #3371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to make the Callback types more consistent with the other stored types in leptos.
try_run
to callable which (in line with other stored types) will returnNone
if the callback had been disposed.impl Dispose
for bothCallback
andUnsyncCallback
Small detail regarding implementation:
The impl of
Callable::run
forUnsyncCallback
andCallback
was inconsistent. One usedtry_with_value
with expect while the other was usingwith_value
.I chose to make them consistent and use
with_value
in both impls. I'm unsure if I chose the right option, perhaps try_with_value was preferable.