Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IntoStyle for (str, Option) #3576

Closed
wants to merge 1 commit into from

Conversation

luxalpa
Copy link
Contributor

@luxalpa luxalpa commented Feb 10, 2025

This is my attempt at allowing (str, Option<T>) in IntoStyles for #3568 . As I am not very familiar with the code base there might be things I am misunderstanding.

I also wanted to fix the case for a ReactiveFunction<Output = Option<T>> however the way I see it it might require a refactor, due to possible overlapping impls.

Also, I feel like in general something like trait IntoStyleValue could be useful.

@gbj
Copy link
Collaborator

gbj commented Feb 14, 2025

Thanks for your work! Having looked at it a little today, I agree with your idea that fixing it for the reactive case requires larger refactoring. I've made a small start and will try to take a crack at it this weekend -- I'm going to leave this open for now until I see what needs to happen.

@gbj
Copy link
Collaborator

gbj commented Feb 15, 2025

Okay, I think I was able to do a more general implementation of this in #3618 — I made the PR against the 0.8 branch as it includes some semver-breaking changes I think. (Good idea to use a helper trait.)

@luxalpa
Copy link
Contributor Author

luxalpa commented Feb 15, 2025

Perfect, thank you!

@gbj gbj closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants