URLs with parenthesis are broken

[fiatjaf]

>>> import mistune
>>> import urllib
>>> import urlparse
>>> 
>>> url = 'https://trello-attachments.s3.amazonaws.com/550878b58559170febf8e69b/500x600/ff07160366332b3962320bdfb1693e3e/download_(2).jpg'
>>> mistune.markdown("here's a [broken URL](%s)" % url)
'<p>here\'s a <a href="https://trello-attachments.s3.amazonaws.com/550878b58559170febf8e69b/500x600/ff07160366332b3962320bdfb1693e3e/download_(2">broken URL</a>.jpg)</p>\n'
>>> urlp = urlparse.urlparse(url)
>>> mistune.markdown("now [it](%s) is not broken anymore" % (urlp.scheme + '://' + urlp.netloc + urllib.quote(urlp.path)))
'<p>now <a href="https://trello-attachments.s3.amazonaws.com/550878b58559170febf8e69b/500x600/ff07160366332b3962320bdfb1693e3e/download_%282%29.jpg">it</a> is not broken anymore</p>\n'

[lepture]

I see. You have () in the URL, which is not safe in the URL.

[tonyseek]

It seems the URL string need to be normalized. Using werkzeug.urls may be better than scheme + '://' + netloc.

from werkzeug.urls import url_parse, url_quote


def safe_url(url):
    parsed = url_parse(url)
    path = url_quote(parsed.path, safe='/%')
    query = url_quote(parsed.query, safe='?=&')
    return parsed.replace(path=path, query=query).to_url()


url = 'https://trello-attachments.s3.amazonaws.com/550878b58559170febf8e69b/500x600/ff07160366332b3962320bdfb1693e3e/download_(2).jpg'
print mistune.markdown("here's a [URL](%s)" % safe_url(url))

There is a similar solution in douban/brownant.

[lepture]

It is not easy to write a proper regex for this situation. I've fix the situation in this case:

[foo](<http://foo.bar.(2).jpg>)

You need to wrap the link with < and >.

[lepture]

Not really solved, but a workaround.

[fiatjaf]

Can I wrap every link, no only the ones with )?

[lepture]

@fiatjaf yes.