Expose default_features as class-level attributes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to add feature types to BlockLexer and InlineLexer without having to copy-paste the methods where their default feature orders are defined.
|
Merged in 70490b6 But I think you will need to do more things: |
|
Thanks for the heads up - I'll have a go at it, and send you more PRs if I find I need them. |
|
Closing this, because the commit was already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to add feature types to subclasses of BlockLexer and InlineLexer, without having to copy-paste the methods where their default feature orders are defined.
Background: We're investigating using mistune for rendering markdown in IPython notebooks (ipython/ipython#6028). One of our requirements is to pass through code in $-delimited mathematical expressions (
$inline$and$$block$$), without trying to render it as markdown (they are rendered by mathjax in the browser). At present, we do this by replacing all such expressions with numbered tokens like@@1@@, sending it to a renderer, and then filling them back in in the HTML. I hope that by using mistune, we can have a more elegant solution where the parser itself knows about these expressions. I think I can see how to do this, but I need a way to add a feature to the lexers.