Please add py.typed so mypy will use and respect type annotations in mistune #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Oct 3, 2023
Types added in lepture/mistune#348 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy will complain that it can't check types for mistune despite someone taking the time to annotate mistune because it lacks a
py.typedfile to signal that it is safe to use the type annotations in mistune.No python touched. I'm assuming you are using
python -m buildas show in in Makefile.lI tested with
clear && rm -rf dist && python -m build && python -m zipfile --list dist/*.whland got
No library code was touched & unless someone runs mypy, this has no impact on how the library works.