Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark theme + jupyter colors #66

Closed
cboettig opened this issue Oct 11, 2024 · 2 comments
Closed

dark theme + jupyter colors #66

cboettig opened this issue Oct 11, 2024 · 2 comments

Comments

@cboettig
Copy link

Thanks for sharing this fantastic theme, it looks great and is easy to work with.

One thing I've noticed is when using the Juypter integration, code-blocks look great in light mode but become nearly impossible to read in dark mode, e.g. taking a screen shot from your docs in dark mode

image

The cell background uses a high-contrast white, while the cell text is very washed out. I think this would look better and be more readable if the cell background used a dark background (similar to say, Jupyter's own dark mode). Is it possible to configure this? (Apologies this is probably a simple css override)

@lepture
Copy link
Owner

lepture commented Oct 14, 2024

Oh, thanks for the feedback. This could be caused by jupter's update. It worked fine before.

@lepture
Copy link
Owner

lepture commented Oct 14, 2024

2024.10.14 is released. This issue has been fixed.

@lepture lepture closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants