Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing period enforcement from PR titles #106

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jun 17, 2018

If users want to have a trailing period they should add it to the PR title instead. PRs with trailing periods would currently get a double period, which this PR fixes.

/cc @rwjblue

@Turbo87 Turbo87 added the bug label Jun 17, 2018
If users want to have a trailing period they should add it to the PR title instead. PRs with trailing periods would currently get a double period, which this commit fixes.
@Turbo87 Turbo87 merged commit 73d7bbe into lerna:master Jun 17, 2018
@Turbo87 Turbo87 deleted the period branch June 17, 2018 12:21
@rwjblue
Copy link
Contributor

rwjblue commented Jun 17, 2018

ZOMG, THANK YOU!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants