Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde visitor for byts with use_avro_rs_unions option #70

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 16, 2024

NOTE: I don't know how to really test if the deserialization is successful but at least it builds now.

Sorry, missed that in #69 and it results in this error when enabling use_avro_rs_unions:

error: expected one of `->`, `<`, `where`, or `{`, found `[`
   --> <generated_file>:100:22
    |
86  |         impl<'de> serde::de::Visitor<'de> for UnionStringBytesVisitor {
    |                                                                       - while parsing this item list starting here
...
100 |             fn visit_[u8]<E>(self, value: &[u8]) -> Result<Self::Value, E>
    |                      ^ expected one of `->`, `<`, `where`, or `{`
...
106 |         }
    |         - the item list ends here

```
error: expected one of `->`, `<`, `where`, or `{`, found `[`
   --> <generated_file>:100:22
    |
86  |         impl<'de> serde::de::Visitor<'de> for UnionStringBytesVisitor {
    |                                                                       - while parsing this item list starting here
...
100 |             fn visit_[u8]<E>(self, value: &[u8]) -> Result<Self::Value, E>
    |                      ^ expected one of `->`, `<`, `where`, or `{`
...
106 |         }
    |         - the item list ends here
```
@lerouxrgd lerouxrgd merged commit 7e0f600 into lerouxrgd:master Aug 17, 2024
2 checks passed
@lerouxrgd
Copy link
Owner

Thanks, nice catch !

@mati865 mati865 deleted the fix-avro-rs-unions branch August 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants