Fix gen code without chrono to handle nullable logical-dates #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this tool to generate my Rust code from Avro schemas, but I want to use something other than Chrono dates. Instead, I would use the
i64
version for my logical dates.The code currently being generated for nullable dates needs to handle this correctly. It will incorrectly try serializing the
Option<i64>
usingchrono::serde::ts_milliseconds_option
.Here is an example of generating the Avro schema
logical_dates.avsc
with chrono dates disabled: