Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved conceal for natbib's commands #2155

Closed
rionda opened this issue Sep 2, 2021 · 7 comments
Closed

Improved conceal for natbib's commands #2155

rionda opened this issue Sep 2, 2021 · 7 comments

Comments

@rionda
Copy link
Contributor

rionda commented Sep 2, 2021

Conceal works correctly for many (not all, see below) of natbib's commands such as \citep, \citet, ..., that start with a lowercase c, but it does not work for any those that starts with an uppercase C, such as \Citep, ... . These commands starting with an uppercase C are used to enforce uppercase names at the beginning of a sentence (see natbib reference, section "Forcing upper case names").

Conceal also does not seem to work for some of natbib's commands, such as \citeauthor, \citeyear, or those starting with \citeal, and possibly others. See the reference linked above for a complete list of natbib's commands.

Thanks for all the work!

@lervag
Copy link
Owner

lervag commented Sep 3, 2021

Conceal works correctly ..., but it does not work for any ...

Conceal also does not seem to work for some of ...

It would be very helpful if you could provide a sample LaTeX snippet that includes all of the commands you find is lacking. Then I could use it for testing while adding them.

Thanks for all the work!

My pleasure :)

@rionda
Copy link
Contributor Author

rionda commented Sep 6, 2021

Here you are:

% "Standard" commands

\citeauthor{jon90} 

\citeauthor*{jon90} 

\citeyear{jon90} 

\citeyearpar{jon90}

% Capital `C` commands

\Citep{jon90}

\Citet{jon90}

\Citealt{jon90}

\Citealp{jon90}

\Citeauthor{jon90}

% Suppressed parentheses commands (i.e., "`\citeal*`" commands)

\citealt{jon90}

\citealt*{jon90}

\citealp{jon90}

\citealp*{jon90}

\citenum{jon90}

\citetext{priv.\ comm.}

lervag added a commit that referenced this issue Sep 6, 2021
@lervag
Copy link
Owner

lervag commented Sep 6, 2021

This should work now, please test.

@lervag lervag closed this as completed Sep 6, 2021
@rionda
Copy link
Contributor Author

rionda commented Sep 6, 2021

I did a couple of tests. Seems to work. Thanks!

@lervag
Copy link
Owner

lervag commented Sep 6, 2021

Good to hear!

@rionda
Copy link
Contributor Author

rionda commented Oct 7, 2021

Sorry to reopen this, but \citeauthor, \citeauthor*, \citeyear, \citeyearpar, \citenum, \citealp and others do not seem to work (anymore? I thought I tested them...)

@lervag
Copy link
Owner

lervag commented Oct 7, 2021

Oh, they should work. Perhaps the natbib package is not loaded? Can you give a proper minimal example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants