Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: two zathura launched after starting compiling #2366

Closed
moetayuko opened this issue Apr 6, 2022 · 3 comments · Fixed by #2367
Closed

regression: two zathura launched after starting compiling #2366

moetayuko opened this issue Apr 6, 2022 · 3 comments · Fixed by #2367
Labels

Comments

@moetayuko
Copy link
Contributor

moetayuko commented Apr 6, 2022

Description

After committing 3b4a5a1, two zathura get launched after starting compiling w/ <localleader>lv in vim8, but nvim works fine.

Readding echos in 3b4a5a1#diff-f7d9b3dc2fb7089c1755af5c49217c00982d466ddac80601ab0bfa8f81522dfbL453-R459 fixed the issue.

I guess the regex ^ needs to be applied to

call s:check_callback(a:msg)
as well?

Steps to reproduce

No response

Expected behavior

No response

Actual behavior

No response

Do you use a latexmkrc file?

No

VimtexInfo

System info:
  OS: Arch Linux
  Vim version: VIM 8.2 (1-4651)
  Has clientserver: true
  Servername: VIM

VimTeX project: t
  base: t.tex
  root: /home/xxx/tmp
  tex: /home/xxx/tmp/t.tex
  main parser: current file
  document class: 
  compiler: latexmk
    engine: -pdf
    options:
      -verbose
      -file-line-error
      -shell-escape
      -synctex=1
      -interaction=nonstopmode
    callback: 1
    continuous: 1
    executable: latexmk
  viewer: Zathura
    xwin id: 0
  qf method: LaTeX logfile
@moetayuko
Copy link
Contributor Author

#2367 seems to be a quick fix

@lervag
Copy link
Owner

lervag commented Apr 6, 2022

Strange; this does not happen on my end. I use the regular minimal files

set nocompatible
" These are correct paths on my end
let &rtp = '../..,' . &rtp
let &rtp .= ',../../after'
filetype plugin indent on
syntax enable

let g:vimtex_view_method = 'zathura'

silent edit main.tex

and

\documentclass{minimal}
\begin{document}
Hello world!
\end{document}

I start with vim -u test.vim, then do \ll. A single window appears. Then \lv - forward search works as expected, still only a single window. Similar with nvim --clean -u test.vim.

@lervag
Copy link
Owner

lervag commented Apr 6, 2022

No, sorry, I'm stupid. I tested after applying your patch. I can confirm it seems to work as expected with your patch and I confirm the bug without it. Thanks!

@lervag lervag closed this as completed in b32c470 Apr 6, 2022
lervag added a commit that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants