-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conceal support for \(sub)*sections
#2022
Conversation
Looks good! Your conceal implementation looks way cleaner than my proof of concept hehe.
I personally don't use
I agree.
Yeah I think g:vimtex_syntax_conceal = {
\ 'styles': 1,
\ 'accents': 1,
\ 'greek': 1,
\ 'math_fracs': 1,
\ 'math_symbols': 1,
\ 'math_super_sub': 1,
\ 'cites': 1,
\ 'fancy': 1,
\ 'sections': 0,
\ 'math_delimiters': 1,
\ 'math_bounds': 1
\ } Adding |
948f04b
to
3c514ed
Compare
Thanks for your thoughts. I've pushed corresponding updates now. I propose to merge this, but I would be happy to hear a second opinion. Not sure if there may be "lurkers" reading this that would be interested in commenting? :) |
Hi, random "lurker" here. First consider My next request is a conceal for
My last request would be the |
Great, happy to "meet" you :)
I've mixed things several times. Typically with things like adding a
Unfortunately, this may be more tricky: 1) I don't think we can conceal multiple lines, and 2) conceals generally only allow to conceal a single "matched part/region" with a single character. More complex conceals are all "hacks" that combine syntax rules in more or less twisted ways. :\
Ah, that was actually an unintended side effect; a bug. Thanks for reporting. I'll revert this immediately. |
g:vimtex_syntax_conceal_default is removed in favour of g:vimtex_syntax_conceal_disable
refer: #2022
54caebe
to
d8a1e54
Compare
I'm sorry about the delay here; I've merged this now. |
See #1978 for context.
Some things to discuss before merging:
This direction of conceals is full of edge cases. For instance, how should we treat
\chapter
? I would perhaps claim we should only allow this particular type of concealment to the specific family\(sub)*section
.I suspect this conceal feature will be much more opinionated. Perhaps it should be off by default? If so, then the
g:vimtex_syntax_conceal_default
becomes "obsolete", but it might have been a bad way to customize things anyways. Perhaps it is better to show the defaults explicitly, allow some defaults to be off, and instead addg:vimtex_syntax_conceal_disable
to make it easy to disable all conceal features for whomever wants that.And, of course: is the current implementation satisfactory?