New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vimtex#util#trim() instead of trim() for Vim versions < 8.1 #2121

Closed

Konfekt wants to merge 1 commit into lervag:master from Konfekt:trim

Contributor

Konfekt commented Jul 28, 2021 •

edited by lervag

Loading

The two occurrences of trim() in

vimtex/autoload/vimtex/parser/bib.vim

Line 34 in 1782e47

\ {_, i -> trim(getline(i))[0] == "@"})

and

vimtex/autoload/vimtex/fold/bib.vim

Line 24 in 3807da1

if empty(trim(getline(a:lnum)))

are replaced by

vimtex/autoload/vimtex/util.vim

Line 192 in 6228f72

function! vimtex#util#trim(str) abort " {{{1

for Vim versions < 8.1.

This creates dependencies outside of the bib file, but they have been there before anyway.


          use vimtex#util#trim() instead of trim() for Vim versions < 8.1

e951bce

The two occurrences of trim() in

  https://github.com/lervag/vimtex/blob/1782e479a0c6a716af3a92d5ed85b65ecfad3dc0/autoload/vimtex/parser/bib.vim#L34

and

  https://github.com/lervag/vimtex/blob/3807da1c530e46fb6a633a2268f6e435b16b657b/autoload/vimtex/fold/bib.vim#L24

are replaced by

  https://github.com/lervag/vimtex/blob/6228f72a8bcf25b31bf1a966de864349ed4ea61c/autoload/vimtex/util.vim#L192

for Vim versions < 8.1.

This creates dependencies outside of the bib file, but they have been
there before anyway.

Owner

lervag commented Aug 1, 2021

Thanks!

lervag added a commit that referenced this pull request


          merge: trim -> vimtex#util#trim

refer: #2121

lervag closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet