Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust path parsed result for pplatex #2369

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Adjust path parsed result for pplatex #2369

merged 1 commit into from
Apr 10, 2022

Conversation

JingMatrix
Copy link
Contributor

Latex log assumes project root to be the start directory

@JingMatrix
Copy link
Contributor Author

I am still using pplatex, it seems their project needs some helps. I'll try to fix some problem there.
But let's fix the problem in vimtex first.

Copy link
Owner

@lervag lervag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason not to accept, but I'll allow you to adjust as commented.

autoload/vimtex/qf/pplatex.vim Outdated Show resolved Hide resolved
autoload/vimtex/qf/pplatex.vim Outdated Show resolved Hide resolved
Latex log assumes project root to be the start directory
@JingMatrix
Copy link
Contributor Author

I force updated my commit now, the first one is a rebase for your commits, and the second one is to adopt your advices.

Thanks for your advice on popd and pushd, it is intuitive just as the shell language.

@lervag
Copy link
Owner

lervag commented Apr 10, 2022

Great, thanks! I'll merge now. :)

@lervag lervag merged commit 7bfcfb7 into lervag:master Apr 10, 2022
@JingMatrix JingMatrix deleted the pplatex-fix branch April 10, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants