Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sioyek forward-search column number #2411

Closed
wants to merge 1 commit into from
Closed

sioyek forward-search column number #2411

wants to merge 1 commit into from

Conversation

JingMatrix
Copy link
Contributor

Well, please don't merge it now; otherwise it will break.
It depends on my pull request ahrm/sioyek#271 , which is waiting for merging.

@JingMatrix JingMatrix closed this Jun 12, 2022
@JingMatrix
Copy link
Contributor Author

That request might be hard to merge, but a new request is more likely to be accepted: ahrm/sioyek#273, so I should reopen it.

@JingMatrix JingMatrix reopened this Jun 12, 2022
@lervag
Copy link
Owner

lervag commented Jun 12, 2022

Thanks! I'll look into this when the sioyek PR has been merged; ok?

@JingMatrix
Copy link
Contributor Author

The pull request is merged now, but for stability reason, current pull-request should wait for next release of sioyek.

@lervag
Copy link
Owner

lervag commented Jun 15, 2022

Sounds good!

lervag added a commit that referenced this pull request Nov 10, 2022
@lervag
Copy link
Owner

lervag commented Nov 10, 2022

Thanks! I noticed that the latest release was in August, which means I should probably have merged this a long time ago. Better late then never, I guess :)

@lervag lervag closed this Nov 10, 2022
lervag added a commit that referenced this pull request Nov 14, 2022
For context, see discussion on Github:
8c3a581

refer: #2411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants