Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating starred command #2612

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Allow creating starred command #2612

merged 1 commit into from
Jan 2, 2023

Conversation

Aster89
Copy link
Contributor

@Aster89 Aster89 commented Dec 31, 2022

I know that tsc exists, but would this change be out of the world?

@lervag
Copy link
Owner

lervag commented Jan 1, 2023

No, this does not seem bad. Perhaps you could include a test for this, e.g. in this file?

@Aster89
Copy link
Contributor Author

Aster89 commented Jan 2, 2023

At the moment if I run MYVIM="vim -T dumb --not-a-term --noplugin -n" make in a clean repo, it fails. Can't even tell how, as the terminal gets rewritten so I'm not sure what come first and what last. I see this (it's a video):
asciicast

Besides, I guess we also want that hitting F7 when the cursor is at | in insert mode in foo*|bar causes the result to be \foo*{bar|, right? If so, my change doesn't work this way yet. I have to improve it :D

@Aster89
Copy link
Contributor Author

Aster89 commented Jan 2, 2023

Besides, I guess we also want that hitting F7 when the cursor is at | in insert mode in foo*|bar causes the result to be \foo*{bar|, right? If so, my change doesn't work this way yet. I have to improve it :D

Done because why not, but I couldn't run the tests.

lervag added a commit that referenced this pull request Jan 2, 2023
@lervag lervag merged commit d4f41a9 into lervag:master Jan 2, 2023
@lervag
Copy link
Owner

lervag commented Jan 2, 2023

Thanks! I fixed the failing tests before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants