-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new bib parser written in Lua #2816
Conversation
d89d308
to
649b83f
Compare
I think there may be an issue. When testing this commit, I've noticed that the time it took for the context-menu to show up wasn't significantly lower. I've tried setting the When debugging I've seen that, in practically all calls to the Also, in the |
Yes, sorry, I didn't update the parser for the context menu yet - I've fixed this locally but not pushed it. Thanks for checking, though! Your too fast for me ;) |
There, I think these are fixed now. |
Yes; the reason for this is that the context menu needs the source file and line number entries that we do not get with the bibtex backend. The Vimscript parser was written mostly to support the context menu feature. |
Ok, I've tested the new commit and everything seems to be working well. |
I've improved the code now. It may not be much faster, but at least it is much easier to understand (IMHO). |
I think that's about as far as I'll go with this. I'll leave the PR open a few days before merging in case anyone wants to test. But I think it should be fine and that it should provide a nice speedup for some people. |
5063292
to
0a84c88
Compare
This is similar to the Vimscript parser ("vim"), but since it is in Lua it is much faster and comparable to the current fastest parser ("bibtex"). refer: #2786
0a84c88
to
0aa412d
Compare
Ok, I've merged this now. @micangl Notice that I've made some quite significant changes both to the Lua and the Vimscript parsers. I believe I've fixed some bugs in the process, and you should consider to either directly rely on the new VimTeX parser in cmp-vimtex or copy and adapt it as you see fit. |
Adding a lua parser for bibtex files.
See #2786.