Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Handlebars 1.0.0-rc.4 #61

Merged
merged 3 commits into from
May 21, 2013
Merged

Conversation

turadg
Copy link
Contributor

@turadg turadg commented May 15, 2013

v1.0.11 / 1.0.0-rc4 - May 13 2013

Commits

@leshill
Copy link
Owner

leshill commented May 15, 2013

Hi @turadg,

Please fix the two failing specs in your branch and we can merge this in!

@turadg
Copy link
Contributor Author

turadg commented May 20, 2013

As requested.

@leshill leshill merged commit 3bee4d5 into leshill:master May 21, 2013
@leshill
Copy link
Owner

leshill commented May 21, 2013

Hi @turadg,

Thanks! Pushed out v0.12.1. I am a little concerned about the patch change – that should not have been required, I will look into it.

@turadg
Copy link
Contributor Author

turadg commented May 21, 2013

Thanks for looking into it. I was a little apprehensive myself, but all the
tests passed. ;)

On Tue, May 21, 2013 at 3:08 PM, Les Hill notifications@github.com wrote:

Hi @turadg https://github.com/turadg,

Thanks! Pushed out v0.12.1. I am a little concerned about the patch change
– that should not have been required, I will look into it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/61#issuecomment-18231687
.

@runemadsen
Copy link

For another time, shouldn't this at least be a 0.13 change for people with ~> in their gemfiles? I started seeing problems like the following (although it's very possible that it's my own fault, as I'm moving stuff around. But it just made me think).

Template was precompiled with an older version of Handlebars than the current runtime. Please update your precompiler to a newer version (>= 1.0.0-rc.4) or downgrade your runtime to an older version (== 1.0.0-rc.3).

@runemadsen
Copy link

Had to clean /tmp to make this work.

@leshill
Copy link
Owner

leshill commented May 21, 2013

Hi @runemadsen,

Yes, that is a good idea for the future. Unfortunately it would not affect devs (possibly a majority?) with no version specified.

To recompile everything, run rake assets:clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants