Contrast function does not correctly handle % thresholds

[karlvr]

It uses threshold.value when it should invoke number(threshold) to correctly convert the percentage to 0-1 range. So if the user passes a percentage the threshold will be > 1 and will always result in returning light.

The test-cases previously used percentages but now have decimal numbers to work around this issue?

I believe changing threshold.value to number(threshold) will correct the issue.

[Synchro]

Thanks, I suspected there was something in here that wasn't right with percentages. It's easy to show there's a problem as thresholds of 0.1 and 10% do not produce the same result.

[karlvr]

Brilliant, thanks for the rapid fix!