-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspicious assignment in directive.js #2191
Labels
Comments
Yes, it looks like my mistake in 09c4311 (brainlessly replaced left side too). |
seven-phases-max
added a commit
that referenced
this issue
Sep 17, 2014
Fixed with 1ecce8b in v2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shouldn't the directive.js accept function assign into
this.rules =
rather then local variablerules
this.value =
rather then local variablevalue
?I could not find a test case that would be broken by this, so it is not a big deal right now. That being said, the assignment is suspect - it works only because currently implemented visitors always return the object from parameter and never something entirely new for directives.
The text was updated successfully, but these errors were encountered: