Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspicious assignment in directive.js #2191

Closed
SomMeri opened this issue Sep 16, 2014 · 2 comments
Closed

Suspicious assignment in directive.js #2191

SomMeri opened this issue Sep 16, 2014 · 2 comments

Comments

@SomMeri
Copy link
Member

SomMeri commented Sep 16, 2014

Shouldn't the directive.js accept function assign into

  • this.rules = rather then local variable rules
  • and this.value = rather then local variable value?

I could not find a test case that would be broken by this, so it is not a big deal right now. That being said, the assignment is suspect - it works only because currently implemented visitors always return the object from parameter and never something entirely new for directives.

@seven-phases-max
Copy link
Member

Yes, it looks like my mistake in 09c4311 (brainlessly replaced left side too).

@seven-phases-max
Copy link
Member

Fixed with 1ecce8b in v2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants