-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Feature - the following functions would be useful: top(), bottom(), left(), right() #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…values from a variable
…x" - (improved comment)
Nice, but I think that would be better if the pull request was for the 1_4_0 branch.. ;) |
Ok, I can do that. But can you explain the 2 branches? |
I will make the changes to the appropriate branch. |
I created a 1_4_0 pull request, #1112. |
@agatronic told me that commits to master for now will be only for serious bug fixes. New features = 1_4_0. |
And yes, master is the 1.3.3 stable version. |
at the same time simple changes are easy to rebase. I'm thinking of moving 1_4_0 to main and deleting the 1_4_0 branch relatively soon, so I guess that advice only applies to things that might have changed already in 1.4.0 and things that will definitely be accepted into 1.4.0 |
p.s. this was only done for 1.4.0 in order to give people somewhere to experiment with some of the big changes planned for 1.4.0 - it isn't normal. |
@agatronic @gustavohenke Thanks for the explanation! I'm excited to start contributing! |
I've implemented these functions.
Please see #1100 for use cases and more info.