Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for local path (cross-platform) #1278

Merged
merged 1 commit into from
Apr 24, 2013
Merged

Conversation

losnir
Copy link
Contributor

@losnir losnir commented Apr 16, 2013

Second try at fixing issue #1272, now with added Unix support.

Second try at fixing issue less#1272, now with added Unix support.
@Piedone
Copy link

Piedone commented Apr 21, 2013

Is this fixing this issue as well? #1238

@losnir
Copy link
Contributor Author

losnir commented Apr 21, 2013

I'm not sure, but we definitely had that issue on less.js 1.3.3 .
I fixed that + more issues on losnir/Crunch - see the latest April commits.

@Piedone
Copy link

Piedone commented Apr 21, 2013

Great, thanks!

I tried your fix but the error I'm experiencing (described in the linked issue) persists. Probably it has to do with a different part of the code base.

@losnir
Copy link
Contributor Author

losnir commented Apr 21, 2013

As I said, I modified some other parts of the code, but I didn't add that to the pull request because it was changed on 1.4.0.

Can you try the following modified file to see if it solves your problem?

https://github.com/losnir/Crunch/blob/master/js/less-1.3.3.mod.js;

@Piedone
Copy link

Piedone commented Apr 21, 2013

Thank you very much for your help! I actually get this error (the one I described in the linked issue) with 1.4b (although I stated otherwise there - got mixed up and am correcting myself there) and I tried your fix with that code (I modded the line in question with your fix in the compiled js file but haven't built less.js myself - not sure if this makes a difference in this particular case). 1.3.3 works for me.
Copying over the whole extractUrlParts() function from your modified 1.3.3 doesn't make a visible difference, the "... wasn't found." error persists.

@losnir
Copy link
Contributor Author

losnir commented Apr 22, 2013

Okay, this looks like an entirely different problem, let me check that.

lukeapage added a commit that referenced this pull request Apr 24, 2013
Better fix for local path (cross-platform)
@lukeapage lukeapage merged commit 1ba5e1e into less:master Apr 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants