Add .gitattributes to .npmignore #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the dependencies, hawk, uses CRLF line endings. If you use less in your project and check in node_modules to source control, git sees the .gitattributes that is packaged with less and obeys it for that subdirectory. This gives you line ending conflicts with hawk. .gitattributes is not relevant to the packaged module and should not be included anyway.
|
Isn't this an issue with hawk? |
|
I don't know if I could consider using CRLF line endings an issue. The problem here is that by installing less through npm, you are getting a repository-specific file that is influencing the parent project's repository, assuming they use git. |
|
Yeh, I plan to get this fixed. |
lukeapage
added a commit
that referenced
this pull request
Jul 20, 2013
Add .gitattributes to .npmignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the dependencies, hawk, uses CRLF line endings. If you use less
in your project and check in node_modules to source control, git sees
the .gitattributes that is packaged with less and obeys it for that
subdirectory. This gives you line ending conflicts with hawk.
.gitattributes is not relevant to the packaged module and should not be
included anyway.