Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower package: purge unnecessary files #1558

Merged
merged 1 commit into from
Sep 22, 2013
Merged

Bower package: purge unnecessary files #1558

merged 1 commit into from
Sep 22, 2013

Conversation

danielfttorres
Copy link
Contributor

This must solved #1557

@jonschlinkert
Copy link
Contributor

I'm not in favor of this. When you use npm to install less.js it's a good chance you don't need those things, but if you're installing less.js via bower there is a chance you will. In other words, the only time I personally use bower to install less.js is when I want to mess around with some of those things you're excluding lol.

@jonschlinkert
Copy link
Contributor

as I think about it though, I sincerely doubt that I represent the avg. Joe on this point... don't weigh my comment into this, I want to defer judgement to someone else on this

@lukeapage
Copy link
Member

I don't use bower, happy to with whatever the norm is there.

Do think it a bit odd that it won't be cleaned up without this.

But if bower is only for browserside and npm for node it makes sense to exclude non browser files.

@jonschlinkert
Copy link
Contributor

if bower is only for browserside and npm for node it makes sense to exclude non browser files.

👍

@danielfttorres
Copy link
Contributor Author

I use bower with yeoman.io (it's very cool). I don't use only bower. And I have LESS installed with node, it's important. But bower is only for browserside and is necessary the files are separated (node ≠ bower).

if bower is only for browserside and npm for node it makes sense to exclude non browser files.

You can see the good 'bower.json' file of the jQuery repository: https://github.com/jquery/jquery/blob/master/bower.json

@lukeapage
Copy link
Member

okay, will put it in and see if anyone shouts.. we can always reverse all or part of it.

lukeapage added a commit that referenced this pull request Sep 22, 2013
Bower package: purge unnecessary files
@lukeapage lukeapage merged commit 9d3a80c into less:master Sep 22, 2013
@Soviut
Copy link

Soviut commented Sep 22, 2013

Seems good to me. Bower should be serving up "browser distributions", while NPM is free to serve entire repositories.

@danielfttorres
Copy link
Contributor Author

Yes, sounds good. Purge unnecessary files is interesting.
And it's working, see:
screen shot 2013-09-22 at 6 13 04 am

But there are some further improvements to be made, and I'm working in this.

@danielfttorres
Copy link
Contributor Author

Sorry, there was an error installing the version 1.5 with bower, and I solved here #1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants