Skip to content

Added +_ for space separated properties merge. #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SomMeri
Copy link
Member

@SomMeri SomMeri commented Jan 8, 2014

Pull request for #1756.

Since everybody seems to consider +_ lesser evil, I implemented it. Merging operator are added in order they are written in, so this:

* {
  transform+: first;
  transform+_: spaced;
  transform+: comma;
}

compiles into:

* {
  transform: first spaced, comma;
}

@seven-phases-max
Copy link
Member

Looks good, though I'd like to see some decision for #1760/#1764 made before, otherwise it becomes harder and harder to sync (but I'm OK to update #1764 with changes if this PR is merged first).

@pixelass
Copy link

pixelass commented Feb 4, 2014

So.. any status updates on this?

@lukeapage
Copy link
Member

For 1.7.0 I guess

lukeapage added a commit that referenced this pull request Feb 8, 2014
@lukeapage
Copy link
Member

merged in @seven-phases-max updated version. Hope you don't mind.

@lukeapage lukeapage closed this Feb 8, 2014
@SomMeri
Copy link
Member Author

SomMeri commented Feb 8, 2014

@lukeapage Thank you.

@pixelass
Copy link

pixelass commented Feb 9, 2014

amazing news. too bad it didn't make the 1.6.3 release though.

@lukeapage
Copy link
Member

I want to release more often so it won't be long.

@pixelass
Copy link

pixelass commented Feb 9, 2014

I noticed.. since 1.4.x (something) you guys are really fast with releases. Thumbs up.

@lukeapage
Copy link
Member

part of that is actually sticking to semver, so we go up a minor version for new features. Before that we were putting features into every release - so 1.3.1 and 1.3.3 are miles apart.

@SomMeri SomMeri deleted the properties-merge branch August 16, 2014 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants