-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement postProcessor callback feature for less.ls browser environment #1835 #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent #1835 Add `jasmine:postProcessor` task and corresponding spec as well
okay |
This is still undocumented on lesscss.org |
Would it make sense for this to be usable outside of "development" in production building as well? Particularly for external libraries that use Less.js programmatically, not so much for a Grunt task. |
@stevenvachon AFAIK that's the plan for the Less.js 2.0 branch (future versions of Less). |
Interesting. Maybe I'll make a PR for 1.x then. |
I wonder if it makes sense to add new feature to 1.x - this is what we're trying to avoid to get v2 earlier. I'd love to see no 1.x anymore (except critical bugfix releases). |
Sure, makes sense. How early might we see v2? |
As soon as we have it to have everything we wanted to I guess :). In fact it's already quite stable for development so I see no problem to PR something you need right into the v2 branch. Though for this particular option I honestly have no idea how it would fit there better, so I'd wait for @lukeapage to reply first. |
@seven-phases-max Agreed. It makes sense to me to do a feature freeze on 1.x. 2.x has a lot of architecture changes so it's not guaranteed the code would be compatible. We could consider maintaining releases for 1.x and 2.x for a while like jQuery, but just bring new features to 2.x. @stevenvachon - There's no set timeline, but @lukeapage may be able to give an estimate. |
@stevenvachon don't worry about a pull request, its next on my list for v2 as part of pulling out cleancss - cleancss will be a post processing plugin re: 1.x, it hasn't had any new features in a long time, its been in bugfix only mode - therefore I am pretty certain it won't have any major (unknown) bugs in it. Since myself, max and maria are the only people who do stuff in less, we do not have the capacity to keep 1.x going alongside 2.x and besides since the breaking changes in less language are minimal (the breaking changes are mainly in the api and consumers of less) I don't think it makes sense |
however @stevenvachon if you would like to help, please take a look at the v2 pull request and I'd love some help there, please just tell me what you'd like to do and we can discuss it. There is a list of things to do on the pull-request. I'd like to complete the breaking changes and then v2 is ready - we cannot wait for the dream list as it will be forever, but once the breaking changes are done it would be okay to bump the version and release |
@lukeapage I couldn't find a similar v2 pull request. I created #2190 instead. Edit |
Add
jasmine:postProcessor
task and corresponding spec as well