Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested lists in JS evaluation #1941

Closed
wants to merge 4 commits into from
Closed

Support nested lists in JS evaluation #1941

wants to merge 4 commits into from

Conversation

phloe
Copy link

@phloe phloe commented Mar 31, 2014

This pull request tries to fix the issue of nested lists getting flattened when passed back and forth between javascript evaluation and Less. See #1939

@phloe phloe changed the title Feature nested lists #1939 Support nested lists in JS evaluation Mar 31, 2014
@lukeapage
Copy link
Member

okay, my opinion is this can go into the next release.

@lukeapage
Copy link
Member

The reason why I am hesitant is because we are trying not to encourage js in less and instead encourage solutions so that js is not needed.

@phloe
Copy link
Author

phloe commented Apr 1, 2014

I did notice the lack of documentation on javascript evaluation on lesscss.org :D

Ideally no one would need to use value/expression lists in eval'ed js. I'm looking forward to a plugin system :)

@matthew-dean
Copy link
Member

Hmm. If we put more JavaScript eval support in, doesn't that work against building the plugin system, since presumably we'll either need to leave in this additional code or have a process of deprecating later?

Or would you classify this simply as a bug fix for an existing feature?

@phloe
Copy link
Author

phloe commented Apr 13, 2014

Ok, I think it's better to just close this PR and force people into writing more advanced stuff in custom functions - instead of inline javascript evals.

@phloe phloe closed this Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants