Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message 2069 #2120

Merged
merged 4 commits into from
Jul 27, 2014

Conversation

SomMeri
Copy link
Member

@SomMeri SomMeri commented Jul 25, 2014

Fixes #2069 - raise an error in case of an empty extend selector.

Note: I'm not sure why values order in source map changed. It does not seem to be caused by my change, it was failing before I made them.

@SomMeri
Copy link
Member Author

SomMeri commented Jul 25, 2014

Travis is failing this with this message:

>> PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/0d8033aa-5104-667c-04c1b3db-2ea3fc33.dmp 0 [ 'PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/0d8033aa-5104-667c-04c1b3db-2ea3fc33.dmp' ]

Did someone encountered it before? I'm not sure how I can solve it. I guess it helps nobody, but it really works on my machine.

@seven-phases-max
Copy link
Member

I'm not sure why values order in source map changed

It depends on the installed source-map module version. v0.1.34 (I had installed before today) produces the old order, while current v0.1.37 produces new one. So I guess it's OK (we need to just update our node modules).

@SomMeri
Copy link
Member Author

SomMeri commented Jul 27, 2014

I merged in upstream changes and tests passed now.

@lukeapage
Copy link
Member

ah thanks @seven-phases-max, on the ball as usual.

lukeapage added a commit that referenced this pull request Jul 27, 2014
@lukeapage lukeapage merged commit ff6fe91 into less:master Jul 27, 2014
@SomMeri SomMeri deleted the misleading-error-message-2069 branch July 27, 2014 19:59
@SomMeri SomMeri restored the misleading-error-message-2069 branch July 28, 2014 11:18
@SomMeri SomMeri deleted the misleading-error-message-2069 branch July 28, 2014 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misleading error message on trailing comma
3 participants