Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolated selector match regression #2217

Merged
merged 1 commit into from
Oct 4, 2014
Merged

Fix interpolated selector match regression #2217

merged 1 commit into from
Oct 4, 2014

Conversation

seven-phases-max
Copy link
Member

Fixes #2216 (regression introduced with #1831, see also comments in #1877).

lukeapage added a commit that referenced this pull request Oct 4, 2014
Fix interpolated selector match regression
@lukeapage lukeapage merged commit 10296d2 into less:2_0_0 Oct 4, 2014
@lukeapage
Copy link
Member

Thanks.
btw I just pushed another big change to the 2_0_0 branch that breaks some of the browser tests - will fix tomorrow, but I figured the sooner big changes get onto the branch the better.

getting close... ;) This change allows drop-in file managers

@lukeapage
Copy link
Member

Oh did you get anywhere with a logger for warnings?

@seven-phases-max
Copy link
Member Author

Oh did you get anywhere with a logger for warnings?

Nope :(

@lukeapage
Copy link
Member

@seven-phases-max I've added a logger system (just have one final test to fix then will push). The idea is there is a logger that can be required (or got from less.logger) and by default it does nothing and the different implementations add listeners - this then means I can remove the silent and verbose options from the core. Not sure if that was what you had in mind, but it means the less core code is alot more tidy (and warnings can be made from anywhere)

@seven-phases-max
Copy link
Member Author

@lukeapage Thanks. I hope I'll be able to get back to it next week or so. Yes, this logging system looks promising. In fact I do not have too much requirements in mind, just two:

  • Warnings should be logged after the code when we compile to a shell console
  • We don't want to pass a context (file/line) into every built-in function so ideally this should somehow be handled transparently.

(And additionally a warning list needs also be available somewhere after/at toCSS/render functions so that external tools could use it on their own).
All this is pretty trivial and I only stalled at the point of composing all that to be not so hardcoded for various environments (i.e. cli/node-lib/browser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants