Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove livereload cache buster param in extractId #2279

Merged
merged 1 commit into from
Nov 9, 2014

Conversation

cgross
Copy link
Contributor

@cgross cgross commented Nov 9, 2014

When using grunt-contrib-watch for livereload and using less.js during development causes the reloading of less styles to happen incorrectly. Basically tiny-lr (used by grunt-contrib-watch) adds a query param to all the files it retrieves like "?livereload={{current time}}". Less.js then uses that url to try to extract the id of the given less file and sees each one as unique instead of the appropriate file.

This causes the livereload/less combination to add the styles from the changed less file but not remove the old ones. More discussion can be found here:
cgross/generator-cg-angular#60

Credit for researching the issue and determining the fix goes to @bpartridge.

@lukeapage
Copy link
Member

Thanks for tracking it down.
personally i compile serverside and use livereload to reload the css - much easier, but anyway will merge this for the next release. Unfortunately you just missed v2.0.0

lukeapage added a commit that referenced this pull request Nov 9, 2014
Remove livereload cache buster param in extractId
@lukeapage lukeapage merged commit 779efe5 into less:master Nov 9, 2014
@cgross
Copy link
Contributor Author

cgross commented Nov 9, 2014

Yea I realize I just missed it. No big deal. Whenever 2.0.1 goes out thats cool.

The thanks really go to @bpartridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants