endlines and comments #2420
Merged
endlines and comments #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
possible fix for less#2370 I have used the following command to test this issue: `printf "p {\r//less\rc:1;\r}\r" | lessc -` I'm not sure if this the most efficient fix. I also tried `var nextNewLine = inp.substr(parserInput.i + 1).search(/\n|\r/);` to replace the `indexOf` but then i expect possible mismatches for `\r\n` which match on the first `\r`.
|
Make your change here instead |
|
indeed only one question mark fix this issue. Nice. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible fix for #2370
I have used the following command to test this issue:
printf "p {\r//less\rc:1;\r}\r" | lessc -I'm not sure if this the most efficient fix.
I also tried
var nextNewLine = inp.substr(parserInput.i + 1).search(/\n|\r/);to replace theindexOfbut then i expect possible mismatches for\r\nwhich match on the first\r.