Nested mixin changing important 2421 #2427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
makeImportant
on mixins and rulesets: #2421makeImportant
must create a new ruleset.makeImportant
must create a new mixin definition. It must not convert mixin into ruleset.Why eval failed: mixin-definition inherited
makeImportant
function from ruleset. AsmakeImportant
cascaded to nested objects, every nested mixin was converted into ruleset and lost all parameters, conditions, etc.So, nested
set-width(@aaa)
in following code:was transformed into:
which failed on undefined variable.