Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for naked url imports #2517

Merged
merged 1 commit into from
Mar 21, 2015
Merged

Quick fix for naked url imports #2517

merged 1 commit into from
Mar 21, 2015

Conversation

seven-phases-max
Copy link
Member

Fixes #2516.

Actually I'm not quite sure: maybe this simplification is too liberal but I did not find any weird consequences except that things like @import ~"some.less"; now work too. Any other value types won't pass through the parser anyway.

@lukeapage
Copy link
Member

Did you check the history to see if its a regression?

@seven-phases-max
Copy link
Member Author

No, I did not. But I have right now: it looks like this was changed in 1.4.0. In 1.3.3 it was like this - though I'm not sure if it's the same piece of code actually... No, my mistake, it's actually a regression of v2 - in 1.7.5 it works as expected. I did not find corresponding commit though.

P.S. It looks like the code in this function was the same for a while, but the breaking change was made elsewhere in the code. Unfortunately I can't find what exactly could affect this.

@lukeapage
Copy link
Member

Anyway, looks fine..

lukeapage added a commit that referenced this pull request Mar 21, 2015
@lukeapage lukeapage merged commit 9de8775 into less:master Mar 21, 2015
@seven-phases-max seven-phases-max deleted the fix-naked-url-import branch April 1, 2015 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@import url(/unqouted/path) fails
2 participants