Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper non-primitive value replacement for % and replace #2530

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Proper non-primitive value replacement for % and replace #2530

merged 1 commit into from
Apr 3, 2015

Conversation

seven-phases-max
Copy link
Member

Fixes #2480 as well as similar code with other non-primitive value types.
E.g.:

replace("007", "0", #135); // "#11335507"   / was "undefined07"
replace("007", "0", 2em);  // "2em07"       / was "207"
%("foo-%s", #123);         // "foo-#112233" / was "foo-undefined"
%("bar-%s", 4px);          // "bar-4px"     / was "bar-4"
// etc.

@seven-phases-max seven-phases-max changed the title Зroper non-primitive value replacement for % and replace Proper non-primitive value replacement for % and replace Mar 31, 2015
@lukeapage
Copy link
Member

looks good will merge manually soon and also do a release before easter..

lukeapage added a commit that referenced this pull request Apr 3, 2015
…alue-replacement-for-format-and-replace

Proper non-primitive value replacement for `%` and `replace`
@lukeapage lukeapage merged commit 7ed9574 into less:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format function with %s, %S options and hex colors
2 participants