Fix comments after named color regression #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return this.namedColor(); | ||
| colorKeyword: function () { |
There was a problem hiding this comment.
I did not put colorKeyword() into color() (like it was in #2775) because that way the function is called approximately twice more often (for no real reason).
(Obviously that way it works only because keyword() handles named colors in all other contexts, so eventually the whole thing will need some refactoring anyway).
seven-phases-max
added a commit
that referenced
this pull request
Feb 6, 2016
…ssion Fix comments after named color regression
|
Should we do a release with this? How significant is it? |
|
less/less-docs#394 (comment). Unless @SomMeri says she is not expecting any (maybe partial) fix for #2798 soon... |
|
@matthew-dean @seven-phases-max I did not gave up on it :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2802.