Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make --depends generate no CSS output #2830

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Conversation

gtalusan
Copy link
Contributor

@gtalusan gtalusan commented Mar 3, 2016

I'm using lessc with Qt/C++ and up until recently I've just been regenerating the stylesheets, but I thought that this could be faster.

I dug around and found the depends flag and it sped up my build process 0 to 💯 real quick.

The only downside is that when lessc is invoked twice, it will generate output twice. I actually only need the dependencies with no output, and then at a later stage during make, the actual output. I see here (#2476) that it's a nice to have feature, so here it is.

The new option is -Mn for short or --depends-no-output. It will exercise the same code path as depends but skip the output stage if depends_no_output is true.

@seven-phases-max
Copy link
Member

I suspect not generating the output file with just the --depends option would look more consistent. (I don't use this feature so I may be missing a use-case where one could need both simultaneously, but #2476 (comment) suggest the same).

@gtalusan gtalusan changed the title add no output option when generating dependencies make --depends generate no output Apr 12, 2016
@gtalusan
Copy link
Contributor Author

Okay, updated --depends to not generate output.

@seven-phases-max
Copy link
Member

Thanks for the update. (I'm actually still in doubt if this can have some undesired side-effects, but since #2476 suggest the same, and it seems like nobody is going to comment this anyway (it's been a month the PR is hanging) - let's just merge and wait for issue reports when it's released :P).

@seven-phases-max seven-phases-max changed the title make --depends generate no output make --depends generate no CSS output Apr 12, 2016
@seven-phases-max seven-phases-max merged commit c5fe893 into less:master Apr 12, 2016
@seven-phases-max
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants