switch to unicode escape sequences for compatibility with strict mode #2835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, when requiring
less
for pragmatic usage with strict mode enabled, a syntax error is thrown because of use of octal escape sequences which are disabled in ES5 strict mode.This patch replaces them with the more universal unicode escape sequences, which fixes the above issue. I wasn't able to find any other places where strict-mode would throw at runtime, but I'd be happy to fix them as I find them and submit additional PRs if the feedback for this one is positive.
I realize this is not a priority and might not even be worth fixing for some, but our current setup enforces strict mode. It'd be great if this could be landed within less.js :)