CI Build Fixes. #2941
Merged
CI Build Fixes. #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd82
changed the title
|
integrated workaround for appveyor_retry from #2943 |
In Short: * Enable Travis Cache to mitigate phantomjs download issues. * Enable Travis & appveyor <retry> functionality to avoid race condition on CI builds and old node.js version (0.10/0.12) Details: Using <https://bitbucket.org/ariya/phantomjs/downloads/> to download phantom (on travis) instead of <http://cnpmjs.org/downloads> because Travis downloads from http://cnpmjs.org/downloads are horribly slow (30k/s) and seem courrpt most of the time (smells like throttling) Travis caching is by branch + build env (node version). But it has a fallback to using the cache from the default branch so it should help even with pull requests (which are new branches). Secondly using <travis_retry> and <appveyor_retry> for <npm install> to workaround race condition on with npm install and older versions of node. mitigates #2898
|
Thanks! |
|
Had a look, but no idea as it seems to only fail on node.js version 6 on travis not on travis in general. It also failed during the execution of the phantomjs tests not during the download phase. Also you may want to look into using something a a bit more modern for testing like Chrome Headless. |
|
@bd82 I agree Chrome Headless is better option. Just don't have the cycles to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Build Fixes.
In Short:
and old node.js version (0.10/0.12)
Details:
Using https://bitbucket.org/ariya/phantomjs/downloads/
to download phantom (on travis) instead of http://cnpmjs.org/downloads
because Travis downloads from http://cnpmjs.org/downloads are horribly slow (30k/s)
and seem courrpt most of the time (smells like throttling)
Travis caching is by branch + build env (node version).
But it has a fallback to using the cache from the default branch
so it should help even with pull requests (which are new branches).
Secondly using travis_retry and appveyor_retry for npm install
to workaround race condition on with npm install and older versions of node.
mitigates #2898