Revert BC changes introduced to contrast in minor release #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearly pushed to the wrong branch. |
|
However not clear what branch to target. Should I target master instead? Of wat branch is used for 2.x development? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2906. In a minor release the third argument was dropped entirely from the
contrastfunction. Breaking existing behavior significantly.A new PR could re-introduce this behavior for 4.x.
Reverted PR was #2754. This reverts commit bcc8ced, reversing
changes made to 2f07cd7.
I'll loop in @matthew-dean as he merged the PR that I propose to revert.