Issue3115 ext in node path #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
|
@robhuzzey Since you had a little trouble understanding how to do this in Less for the first time, is there anything that could be added or improved to make contributing to Less easier for yourself or others in the future? |
|
Thanks @matthew-dean yes, I didn't fully understand that each It's really obvious to me now, but just adding a line of two in the Docs pointing that out would have really helped me out :) I'm happy to do this if I have a little time later, although I'm not sure if it lives in here: http://lesscss.org/usage/#developing-less or here: https://github.com/less/less.js/blob/3.x/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue: #3115 & I'm hoping a few of the other issues I have seen around paths & webpack?