Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update source_map to 0.6.x #3180

Merged
merged 3 commits into from
May 7, 2018
Merged

update source_map to 0.6.x #3180

merged 3 commits into from
May 7, 2018

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Feb 25, 2018

#3179 typescript definitions of source_map are available as part of source-map package from 0.6.0 .
Needed by downstream projects. hence upgrading source_map to 0.6.x

@akkumar akkumar changed the title update source_map to 0.7.x update source_map to 0.6.x Feb 25, 2018
@matthew-dean matthew-dean merged commit 0c0229c into less:master May 7, 2018
@matthew-dean
Copy link
Member

Thanks!

@akkumar akkumar deleted the sourcemap_0_7 branch May 7, 2018 04:30
@akkumar
Copy link
Contributor Author

akkumar commented May 7, 2018

Great thanks. @matthew-dean . I assume this is now part of 3.0.4 release ?

(Given the nature of change - I was wondering if bumping up the minor version to 3.1.0 might be appropriate ? )

Also independently, happened to look at - https://github.com/less/less.js/blob/master/CHANGELOG.md , and https://github.com/less/less.js/releases , it does not seem to contain the changelog of the recent releases , 3.0.4 - say. Would it be possible to capture the same for reference purposes ?

@matthew-dean
Copy link
Member

Given the nature of change

@akkumar Can you elaborate? You mean because it's not so much a bug fix but a feature bump? Maybe, technically, yes.

I probably won't have time to do an update for the Changelog. You're welcome to submit a PR for it.

@akkumar
Copy link
Contributor Author

akkumar commented May 9, 2018

You mean because it's not so much a bug fix but a feature bump?

So source map 0.6.x+ (this patch) does enforce node compatibility of node 6+ . Something not expected of a minor release version upgrade usually.

@akkumar
Copy link
Contributor Author

akkumar commented May 9, 2018

You're welcome to submit a PR for it.

#3207 added for the same , capturing this change at the minimum

@matthew-dean
Copy link
Member

So source map 0.6.x+ (this patch) does enforce node compatibility of node 6+

Oh. That wasn't clear from this PR, unfortunately. I thought it was adding Node support, not adding a minimum Node version requirement. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants