Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Franziskus1988 @seven-phases-max
This solves this in hopefully a more elegant way, by doing the following:
require.resolve
do its magic for any non-absolute or non-explicit paths, in file manager. That's much more intelligent for a Node environment than us trying to figure out where the clean-css plugin might be in relation to Less.I also added an additional command-line test to hopefully replicate the issue of calling
lessc
from a non-project-root path, and I updated test output to reflect when an NPM-resolved directory was tested. We could probably use error tests for non-existent plugin paths, but regardless, I think this covers the bases.@Franziskus1988 Could you test this fork and make sure it works for you?