fix: browser cache is always considered stale if .modifyVars wasn't set #3239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem this fixes is the following: Assume
modifyVars
is not used, i.e. it'snull
.In
cache.setCSS
, the:vars
cache item is not set, becausemodifyVars
is falsy in thisif
statement.Therefore, in
cache.getCSS
, we're retrieving a non-existent item from the cache, and sovars
isnull
.But
modifyVars
, which isnull
at function call time, is them defaulted to{}
. In particular, in the check whether the cache is up-to-date,modifyVars
is never falsy.Thus
!modifyVars && !vars
is never truthy, and the up-to-date decision comes down toJSON.stringify(modifyVars) === vars
, which is"{}" === null
and thus false.So the locally cached version is never used.