Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated Buffer constructor (#3305) #3307

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@gabrielschulhof
Copy link
Contributor Author

Fixes #3305

@matthew-dean
Copy link
Member

Wait..... how is dist/less.js affected / changed? That should be auto-generated from grunt dist. What is creating that Buffer in the browser version?

I don't see any dependency changes, so this PR doesn't make sense how that dist file is being generated.

@matthew-dean
Copy link
Member

Oh, I see.... it's being added by Browserify, but why....... 🤔

@matthew-dean
Copy link
Member

Can you rebuild this PR, ommitting changes to dist/ ?

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof
Copy link
Contributor Author

@matthew-dean I have now updated the PR.

@matthew-dean matthew-dean merged commit 6155c4d into less:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants