Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that you pulled my work on ARGB input. I have since rethought my approach. ARGB input is not particularly interesting/useful. Only IE uses it, and then only for gradient filters. For a long-term feature, it probably isn't worth it. That is also combined with the fact that it only worked for function parameters like lighten/darken, not for raw color input, which is included verbatim by the parser without processing. I have removed ARGB input with this patch.
That said, ARGB output is definitely needed for my projects, again for IE's filters. With this patch, a user can specify rgba(...) format for their gradients and output the appropriate IE filter with corresponding #aarrggbb entries, even after being processed by the color functions.
Test cases included as well.
Finally, there is a fix to avoid a client-side scripting error (browser.js) in IE. I've been using this fix in-house for a while now and had forgotten that you hadn't applied similar patches from others in the past.
Best wishes,
Miles Elam