New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pollute window object in less-browser bootstrap #3352

Merged

matthew-dean merged 1 commit into less:master from gaiazov:fix-window-key

Jan 12, 2019

Contributor

gaiazov commented Jan 11, 2019

The key variable in bootstrap.js is not properly declared, which causes it to be added to the global window object.

This PR declares the key variable as var


Do not pollute window object in less-browser bootstrap

0ba27f3

Signed-off-by: Leonid Gaiazov <leonid.gaiazov@appian.com>

kpink224 approved these changes

View reviewed changes

lyndsey-ferguson approved these changes

View reviewed changes

Member

matthew-dean commented Jan 12, 2019

Nice catch!

matthew-dean merged commit b50515c into less:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment