Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #3398 Add flag to disable sourcemap url annotation #3517

Merged

Conversation

hirosato
Copy link
Contributor

Small doubts
Shall I use positive form for the property? I mean using appendSourcemapUrlAnnotation, for example, instead of disableSourcemapAnnotation sounds more straightforward for me. In other words, disableSourcemapAnnotation: false/true looks a little bit confusing.
--source-map-no-annotation, on the other hand, looks ok for me since it does not have true/false value with it.

@hirosato hirosato marked this pull request as draft June 13, 2020 07:00
@hirosato hirosato changed the title Add flag to disable sourcemap url annotation Resolve #3398 Add flag to disable sourcemap url annotation Jun 13, 2020
@hirosato hirosato force-pushed the add-flag-to-disable-sourcemap-url-annotation branch from 458d2d3 to 1c4c51a Compare June 13, 2020 07:13
@hirosato hirosato marked this pull request as ready for review June 13, 2020 07:13
@matthew-dean
Copy link
Member

"Disable" seems ok since having the annotation present by default is the intuited (default) behavior.

@matthew-dean matthew-dean merged commit a3641e4 into less:master Jun 17, 2020
@hirosato
Copy link
Contributor Author

"Disable" seems ok since having the annotation present by default is the intuited (default) behavior.

I get it. thank you for review and comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants